test: Re-add basic test for tui module#81
Merged
Valentin-v-Todorov merged 2 commits intoTheDevOpsBlueprint:mainfrom Oct 10, 2025
Merged
test: Re-add basic test for tui module#81Valentin-v-Todorov merged 2 commits intoTheDevOpsBlueprint:mainfrom
Valentin-v-Todorov merged 2 commits intoTheDevOpsBlueprint:mainfrom
Conversation
Readding tests for the TUI module. Previous work was merged after the record_history changes, causing failures in main. This should resolve. As with the original work, rhis adds some basic tests to get coverage on some of the common rendering code. Full test coverage will take a bit more effort.
amcintosh
force-pushed
the
feature/add-tests-tui-module
branch
4 times, most recently
from
7b5b452 to
a08657a
Compare
These are on older Python versions (3.8, 3.9) that had lesser typing
support.
Failed tests:
```
alix/render.py:12: in Render
def _split_keep_ws(self, s: str) -> list[str | Any]:
E TypeError: unsupported operand type(s) for |: 'type' and '_SpecialForm'
```
```
alix/shell_integrator.py:61: in ShellIntegrator
def preview_aliases(self, target_file: Optional[Path] = None) -> tuple[str, str]:
E TypeError: 'type' object is not subscriptable
```
amcintosh
force-pushed
the
feature/add-tests-tui-module
branch
from
a08657a to
0ba7eae
Compare
Closed
Contributor
|
@amcintosh LGTM ! GGs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What does this PR do?
Readding tests for the TUI module. Previous work was merged after the record_history changes, causing
failures in main. This should resolve.
As with the original work, rhis adds some basic tests to get coverage on some of the common rendering code. Full test coverage will take a bit more effort.
Related Issue
Fixes #29 and PR 75
Type of change
Testing